@ArmaanMcleod Since it is a breaking change I suggest to wrap this in an experimental feature (you can find examples in our code). Then I can review and merge since it is already approved by WG.

@iSazonov Interesting. I thought since it was accepted as bucket 3 breaking change it would not need an experimental feature. I did not see that requirement in the issue.

In any case would be good to move this along so I will create an experimental feature for this.

What should the experimental feature be called?

Although it's a bracket 3, it's still a breaking change. The experimental feature allows us to minimize risks and get feedback faster.
Name could be PSJoinPathChildArray. You can see examples with Get-ExperimentalFeature cndlet.

@iSazonov This one actually doesn't make much sense to enable experimental feature, since we are changing the type of ChildPath from string to string[]. We can't have a parameter type change be wrapped in experimental feature.

We can't have a parameter type change be wrapped in experimental feature.

We have ExperimentalAttribute. See https://github.com/daxian-dbw/PowerShell/blob/d12230f1888ea0226df0e4e0e2e0de2f9e8c0a1e/test/powershell/engine/ExperimentalFeature/assets/ExpTest/ExpTest.cs

GitHub

PowerShell/test/powershell/engine/ExperimentalFeature/assets/ExpTest/ExpTest.cs at d12230f1888ea0226df0e4e0e2e0de2f9e8c0a1e · daxian-dbw/PowerShell

PowerShell for every system. Contribute to daxian-dbw/PowerShell development by creating an account on GitHub.

@iSazonov Thats really interesting. However even if you do:

[Experimental(ExperimentalFeature.PSJoinPathChildArray, ExperimentAction.Show)]
public string[] ChildPath { get; set; }

How do you also make the previous parameter:

public string ChildPath { get; set; }

Also show when the experimental feature is disabled? in C# we can't have two properties have the same name but different type. Maybe I am misunderstanding how this works...

in C# we can't have two properties have the same name but different type.

Yes, it would be too tricky wrap in experimental feature. Let's leave as is.

📣 Hey @ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Microsoft Forms