You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So to make sure the HandleDoubleAndSingleQuote method in CompletionHelpers class is covered from regression, I have added tests to ensure code is covered by regressions.
If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
iSazonov
added
CL-General
Indicates that a PR should be marked as a general cmdlet change in the Change Log
CL-Test
Indicates that a PR should be marked as a test change in the Change Log
labels
Mar 15, 2025
ArmaanMcleod
changed the title
Add XUnit test for all methods in CompletionHelpers class
Add XUnit test for HandleDoubleAndSingleQuote in CompletionHelpers class
Mar 15, 2025
I suggest to add only TestHandleDoubleAndSingleQuote tests in the PR. I have many questions for rest.
All good @iSazonov. I have only included test for HandleDoubleAndSingleQuote. I think out of all methods this one is important to have tests because the logic itself is quite complicated and probably very easy to introduce regression 😄.
@iSazonov Looks like unrelated packaging failures for Windows CI. Might need a rerun. Not sure though if this can auto merge with PSResourceGet and CodeFactor issues.
CL-TestIndicates that a PR should be marked as a test change in the Change Log
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iSazonov
added
CL-General
ArmaanMcleod
changed the title
PR Summary
So to make sure the
HandleDoubleAndSingleQuotemethod in CompletionHelpers class is covered from regression, I have added tests to ensure code is covered by regressions.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).