KEMBAR78
[release/v7.5] Fix PSMethodInvocationConstraints.GetHashCode method by pwshBot · Pull Request #25306 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@pwshBot
Copy link
Collaborator

@pwshBot pwshBot commented Apr 10, 2025

Backport of #24965 to release/v7.5

Triggered by @TravisEz13 on behalf of @crazyjncsu

Original CL Label: CL-General

/cc @PowerShell/powershell-maintainers

Impact

Choose either tooling or Customer impact.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Customer Impact

  • Customer reported
  • Found internally

Large amount of memory used in almost every method invocation.

Regression

  • Yes
  • No

7.4 - Performance regression.

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

No tests changed, because it's a perf issue not a functional issue

Risk

  • High
  • Medium
  • Low

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

There is a difference between GetHashCode for array object itself and cumulative GetHashCode based on hashes of the array members.
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Apr 22, 2025
@TravisEz13 TravisEz13 added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log BackPort-7.5.x-Approved labels May 14, 2025
@daxian-dbw daxian-dbw removed the Review - Needed The PR is being reviewed label May 14, 2025
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 merged commit 2bab6df into PowerShell:release/v7.5 May 14, 2025
40 of 46 checks passed
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented May 14, 2025

📣 Hey @@pwshBot, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.5.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants