-
Notifications
You must be signed in to change notification settings - Fork 8k
[release/v7.5] Move .NET method invocation logging to after the needed type conversion is done for method arguments #25357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/v7.5] Move .NET method invocation logging to after the needed type conversion is done for method arguments #25357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for 1 issue.
|
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
📣 Hey @@pwshBot, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
|
pwshBot:backport/release/v7.5/25022-7be2e9e8f |
|
yes |
|
pwshBot:backport/release/v7.5/25022-7be2e9e8f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ebaone
Backport of #25022 to release/v7.5
Triggered by @TravisEz13 on behalf of @daxian-dbw
Original CL Label: CL-Engine
/cc @PowerShell/powershell-maintainers
Impact
Choose either tooling or Customer impact.
Tooling Impact
Customer Impact
Issue with some parameters to calls not getting logged to AMSI.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
manually tested by turning on the console log
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]