KEMBAR78
Add more tests for `PSForEach` and `PSWhere` methods by daxian-dbw · Pull Request #25519 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@daxian-dbw
Copy link
Member

Summary

This is a follow-up of the PR #25511 to add more tests for PSForEach and PSWhere methods.
The intrinsic methods are handled in 3 places in the binder to cover 3 scenarios. A few more tests are added to cover all those scenarios.

@daxian-dbw daxian-dbw added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label May 6, 2025
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment.

@daxian-dbw daxian-dbw merged commit 52150fd into PowerShell:master May 9, 2025
34 of 35 checks passed
@daxian-dbw daxian-dbw deleted the foreach-where-test branch May 9, 2025 18:15
@daxian-dbw
Copy link
Member Author

@iSazonov Thanks for the review!

@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented May 9, 2025

📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants