Specify .NET Search by Build Type #25837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
approved these changes
Aug 7, 2025
|
Updated version of #24992 |
daxian-dbw
added
the
CL-BuildPackaging
TravisEz13
reviewed
Aug 20, 2025
TravisEz13
reviewed
Aug 20, 2025
….props for clarity and maintainability
TravisEz13
approved these changes
Aug 20, 2025
TravisEz13
reviewed
Aug 20, 2025
TravisEz13
reviewed
Aug 20, 2025
adityapatwardhan
approved these changes
Aug 20, 2025
|
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
21 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request updates the build configuration logic to better distinguish between different deployment types and set related properties more clearly. The main changes introduce an
AppDeploymentproperty that controls where the app host should be searched for, improving clarity and maintainability for framework-dependent, global tool, and self-contained deployments.Build configuration improvements:
AppDeploymentproperty inbuild.psm1to explicitly specify deployment type (GlobalTool,FxDependent, orSelfContained), replacing the previous approach of directly toggling properties based on runtime options.PowerShell.Common.propsto defineAppHostDotNetSearchbased on the newAppDeploymentproperty, ensuring the correct search locations are used for each deployment scenario.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header