KEMBAR78
Fix the APIScan pipeline by daxian-dbw · Pull Request #26016 · PowerShell/PowerShell · GitHub
Skip to content

Fix the APIScan pipeline #26016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 10, 2025
Merged

Fix the APIScan pipeline #26016

merged 6 commits into from
Sep 10, 2025

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Sep 8, 2025 •
edited
Loading

PR Summary

Fix a few things of the APIScan pipeline:

  1. When removing unused runtimes, keep the win and win-x64 runtime folders.
  2. Stop downloading getfilesiginforedist.dll from Azure blob. The original getfilesiginforedist.dll produced from the build works fine with the symbols retrieved by dotnet-symbols.

The APIScan validation run: https://dev.azure.com/mscodehub/PowerShellCore/_build/results?buildId=623994&view=results

PR Checklist

@daxian-dbw daxian-dbw marked this pull request as ready for review September 8, 2025 21:07
@daxian-dbw daxian-dbw requested review from a team and jshigetomi as code owners September 8, 2025 21:07
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 8, 2025
@daxian-dbw
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 self-assigned this Sep 10, 2025
@daxian-dbw daxian-dbw merged commit cfc0bcd into PowerShell:master Sep 10, 2025
37 checks passed
@daxian-dbw daxian-dbw deleted the apiscan branch September 10, 2025 21:57
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 10, 2025 •
edited by unfurl-links bot
Loading

📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@jshigetomi jshigetomi Awaiting requested review from jshigetomi jshigetomi is a code owner

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daxian-dbw @TravisEz13 @adityapatwardhan