KEMBAR78
Include `stylecop.json` in build by xtqqczze · Pull Request #26040 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@xtqqczze
Copy link
Contributor

Include stylecop.json as an additional file in MSBuild, otherwise it has no effect.

@xtqqczze xtqqczze requested review from a team and jshigetomi as code owners September 11, 2025 16:25
@xtqqczze
Copy link
Contributor Author

cc: @TravisEz13

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Sep 18, 2025
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Sep 24, 2025
@iSazonov
Copy link
Collaborator

/azp run PowerShell-Windows-Packaging-CI, PowerShell-CI-linux-packaging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Sep 24, 2025
@xtqqczze
Copy link
Contributor Author

@TravisEz13 Should this PR also include workflow triggers for stylecop.json:

  • .github/workflows/linux-ci.yml
  • .github/workflows/macos-ci.yml
  • .github/workflows/windows-ci.yml

@iSazonov
Copy link
Collaborator

iSazonov commented Oct 9, 2025

@xtqqczze Please rebase.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Oct 9, 2025
@xtqqczze xtqqczze force-pushed the include-stylecopjson branch from ec967ba to 4e639b5 Compare October 9, 2025 12:45
@xtqqczze xtqqczze force-pushed the include-stylecopjson branch from 4e639b5 to ad33672 Compare October 9, 2025 12:45
@xtqqczze
Copy link
Contributor Author

@iSazonov Please approve pending checks.

@iSazonov
Copy link
Collaborator

/azp run PowerShell-Windows-Packaging-CI, PowerShell-CI-linux-packaging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@xtqqczze xtqqczze requested a review from TravisEz13 October 11, 2025 18:55
@xtqqczze
Copy link
Contributor Author

@jshigetomi please review

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Oct 23, 2025
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 23, 2025

@jshigetomi @TravisEz13 Please approve.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants