KEMBAR78
Fix race condition in RemoteHyperVSocket by TravisEz13 · Pull Request #26057 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Sep 15, 2025

PR Summary

This pull request introduces support for a new V2 socket server mode in PowerShell's console host, along with improvements to test execution and workflow triggers. The main focus is on enabling the -V2SocketServerMode command-line parameter (Windows only), which requires a token and UTC timestamp for secure operation. Additionally, the build system and CI workflows are enhanced for better flexibility and debugging.

V2 Socket Server Mode (Windows-only enhancements)

  • Added support for the -V2SocketServerMode command-line parameter, which enables a new socket server mode requiring both a token (-Token) and a UTC timestamp (-UTCTimestamp). The parser, validation logic, and server startup flow have been updated accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Updated HyperVSocketMediator and related client/server classes to support token-based authentication and the new session ID socket for V2 mode. [1] [2] [3] [4]

Command-line Parameter Parsing Improvements

  • Extended the ParameterBitmap enum to include the new V2 socket server mode and ensured all bitmasks are properly sized for future expansion. [1] [2]
  • Added error messages for missing mandatory arguments and parameters, improving user feedback when required options are omitted. [1] [2]

Build and Test System Improvements

  • Enhanced the Start-PSxUnit function to support test filtering and debug logging, allowing more granular and verbose test execution. [1] [2]

CI Workflow Enhancements

  • Updated GitHub Actions workflow triggers to include branches matching the *-feature pattern, ensuring feature branches are properly built and tested. [1] [2] [3]

PR Context

Already fixed in v7.5.3 and v7.4.12

PR Checklist

@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Sep 15, 2025
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daxian-dbw
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@TravisEz13 TravisEz13 merged commit 42e86f6 into PowerShell:master Sep 15, 2025
42 of 43 checks passed
@TravisEz13 TravisEz13 deleted the fixracecondition branch September 15, 2025 18:37
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 15, 2025

📣 Hey @@TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants