KEMBAR78
3.x: Add concatEagerDelayError across by akarnokd · Pull Request #6899 · ReactiveX/RxJava · GitHub
Skip to content

3.x: Add concatEagerDelayError across #6899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2020
Merged

3.x: Add concatEagerDelayError across #6899

merged 2 commits into from
Jan 30, 2020

Conversation

@akarnokd
Copy link
Member

Flowable, Observable, Maybe and Single now have a concatEagerDelayError, delegating to the appropriate concatMapEagerDelayError operator.

In addition, Maybe and Single received an overload concatEager(Iterable, int) to expose the maxConcurrency option already present in the rest of the types.

Note that Completable.concatEagerDelayError is essentially the same as mergeDelayError because there are no items to keep emitting in order.

Resolves #6880

The Flowable and Observable variant of concatEager also received fresh marble diagrams. (Related #5813)

Flowable

image
image
image
image

image
image
image
image

Observable

image
image
image
image

image
image
image
image

Maybe

image
image

image
image
image
image

Single

image
image

image
image
image
image

@akarnokd akarnokd added this to the 3.0 milestone Jan 30, 2020
This was referenced Jan 30, 2020
Closed
Closed
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #6899 into 3.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6899      +/-   ##
============================================
+ Coverage     98.26%   98.26%   +<.01%     
- Complexity     6597     6618      +21     
============================================
  Files           742      742              
  Lines         47400    47426      +26     
  Branches       6443     6443              
============================================
+ Hits          46578    46604      +26     
  Misses          300      300              
  Partials        522      522
Impacted Files Coverage Δ Complexity Δ
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <ø> (ø) 140 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 565 <6> (+4) ⬆️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 214 <7> (+6) ⬆️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <100%> (ø) 196 <8> (+6) ⬆️
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 595 <5> (+4) ⬆️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.66% <0%> (-4.69%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 91.26% <0%> (-2.39%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.19%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95% <0%> (-1.67%) 2% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.09% <0%> (-0.91%) 2% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4bb8b...fae8770. Read the comment docs.

@akarnokd akarnokd merged commit 81f0569 into ReactiveX:3.x Jan 30, 2020
@akarnokd akarnokd deleted the ConcatEagerDelayError3x branch January 30, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3.x Cleanup Documentation Enhancement

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3.x: Add concatEagerDelayError across

1 participant

@akarnokd