Add RBS support for allow_incompatible_override_visibility modifier

Morriar · Morriar · commit b06b1b6afbe3 · 2025-10-10T13:31:21.000-04:00
Signed-off-by: Alexandre Terrasa &lt;alexandre.terrasa@shopify.com&gt;
diff --git a/lib/rbi/rbs_printer.rb b/lib/rbi/rbs_printer.rb
@@ -337,6 +337,8 @@ def visit_method(node)
       if node.sigs.any?(&:is_override)
         if node.sigs.any?(&:allow_incompatible_override)
           printl("# @override(allow_incompatible: true)")
+        elsif node.sigs.any?(&:allow_incompatible_override_visibility)
+          printl("# @override(allow_incompatible: :visibility)")
         else
           printl("# @override")
         end
diff --git a/test/rbi/rbs_printer_test.rb b/test/rbi/rbs_printer_test.rb
@@ -397,8 +397,11 @@ def foo; end
         sig { override(allow_incompatible: true).returns(T.nilable(String)) }
         def bar; end
 
-        T::Sig::WithoutRuntime.sig { abstract.returns(String) }
+        sig { override(allow_incompatible: :visibility).returns(T.nilable(String)) }
         def baz; end
+
+        T::Sig::WithoutRuntime.sig { abstract.returns(String) }
+        def qux; end
       RBI
 
       # Modifiers are ignored in RBS, but we generate comments for them
@@ -413,9 +416,12 @@ def foo: -> void
         # @override(allow_incompatible: true)
         def bar: -> String?
 
+        # @override(allow_incompatible: :visibility)
+        def baz: -> String?
+
         # @without_runtime
         # @abstract
-        def baz: -> String
+        def qux: -> String
       RBI
     end
 
