KEMBAR78
Accessible action compatibility table by minorninth · Pull Request #80 · WICG/aom · GitHub
Skip to content

Conversation

minorninth
Copy link
Collaborator

No description provided.

@alice
Copy link
Member

alice commented Jul 21, 2017

👍

@minorninth
Copy link
Collaborator Author

I'm going to merge this and then follow up based on Issue 81

@asurkov
Copy link
Member

asurkov commented Jul 26, 2017

sure, sorry for being slow on review, I'll open an issue if I find anything.

Copy link
Member

@asurkov asurkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with me, sorry it took that long

spec/phase2.html Outdated
</tr>
<tr>
<td>1</td>
<td>Select</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

spec/phase2.html Outdated
</tr>
<tr>
<td>1</td>
<td>SecondaryClick</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you use IAccessibleAction and AtkAction as a fallback whenever the API doesn't provide a better match?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed in this case

spec/phase2.html Outdated
</tr>
<tr>
<td>2</td>
<td>ReplaceText</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ATK case it may be a combination of select and paste actions.

I'm not sure if we consider the actions as they serve the dual propose, i.e. can be used by users and can be defined by users for custom accessibility. So in the first case, it might be nice to have this action. For the latter case, it's overhead for the users for sure.

spec/phase2.html Outdated
</tr>
<tr>
<td>2</td>
<td>ScrollToPoint</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, how you order these actions, seems pretty random with me. So, do we want to keep it in alphabetical order or grouping them somehow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was ordering roughly by how many platforms each action is on, from most universal to least universal

spec/phase2.html Outdated
</tr>
<tr>
<td>1</td>
<td>Focus</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atk_component_grab_focus for ATK

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

spec/phase2.html Outdated
</td>
<td>
</td>
<td>atk_editable_text_set_text_contents</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last rows are pretty sketchy. I agree it's good to have them somewhere for a big picture, but I'm not sure if they deserve this table space :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I could pull them out of the table and just list things that aren't very universal

@minorninth minorninth merged commit 3e96e0a into WICG:gh-pages Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants