-
Notifications
You must be signed in to change notification settings - Fork 59
Accessible action compatibility table #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 |
I'm going to merge this and then follow up based on Issue 81 |
sure, sorry for being slow on review, I'll open an issue if I find anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with me, sorry it took that long
spec/phase2.html
Outdated
</tr> | ||
<tr> | ||
<td>1</td> | ||
<td>Select</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
spec/phase2.html
Outdated
</tr> | ||
<tr> | ||
<td>1</td> | ||
<td>SecondaryClick</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should you use IAccessibleAction and AtkAction as a fallback whenever the API doesn't provide a better match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed in this case
spec/phase2.html
Outdated
</tr> | ||
<tr> | ||
<td>2</td> | ||
<td>ReplaceText</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ATK case it may be a combination of select and paste actions.
I'm not sure if we consider the actions as they serve the dual propose, i.e. can be used by users and can be defined by users for custom accessibility. So in the first case, it might be nice to have this action. For the latter case, it's overhead for the users for sure.
spec/phase2.html
Outdated
</tr> | ||
<tr> | ||
<td>2</td> | ||
<td>ScrollToPoint</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, how you order these actions, seems pretty random with me. So, do we want to keep it in alphabetical order or grouping them somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was ordering roughly by how many platforms each action is on, from most universal to least universal
spec/phase2.html
Outdated
</tr> | ||
<tr> | ||
<td>1</td> | ||
<td>Focus</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atk_component_grab_focus for ATK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
spec/phase2.html
Outdated
</td> | ||
<td> | ||
</td> | ||
<td>atk_editable_text_set_text_contents</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last rows are pretty sketchy. I agree it's good to have them somewhere for a big picture, but I'm not sure if they deserve this table space :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I could pull them out of the table and just list things that aren't very universal
No description provided.