KEMBAR78
Comparing rename-effect-fields...combine-flags-and-subtreeflags · acdlite/react · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: acdlite/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: rename-effect-fields
Choose a base ref
...
head repository: acdlite/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: combine-flags-and-subtreeflags
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 39 files changed
  • 1 contributor

Commits on Sep 4, 2020

  1. Rename effect fields (facebook#19755) 

    - `effectTag` -> `flags`
- `subtreeTag` -> `subtreeFlags`
    @acdlite
    acdlite authored Sep 4, 2020
    Configuration menu
    Copy the full SHA
    1665443 View commit details
    Browse the repository at this point in the history

  2. Combine Flags and SubtreeFlags types 

    Because the `subtreeFlags` is the union of all the flags present in
a subtree, we can use the same type as `flags`.

One practical benefit is that we can bubble up the flags from the
children with a single `|=` operator.

Structurally, everything else about the effect algorithm is unchanged.
    @acdlite
    acdlite committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    13be8c3 View commit details
    Browse the repository at this point in the history
Loading