KEMBAR78
Add FragmentManager extension for transactions by romtsn · Pull Request #161 · android/android-ktx · GitHub
Skip to content
This repository was archived by the owner on Nov 14, 2018. It is now read-only.

Conversation

@romtsn
Copy link
Contributor

@romtsn romtsn commented Feb 6, 2018

Add extension to execute FragmentTransaction in a handy way

fragmentManager.transact {
   remove(fragmentOne)
   add(R.id.fragment_container, fragmentTwo)
}

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@romtsn
Copy link
Contributor Author

romtsn commented Feb 6, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@JakeWharton
Copy link
Contributor

Thanks for taking the time to make the PR (with tests!), but we would like to encourage that developers only use the support library fragments. The next version of Android will deprecate the version of fragments that are part of the platform. Thus, we aren't going to add any extensions to support them in this project.

@JakeWharton JakeWharton closed this Feb 6, 2018
@romtsn romtsn deleted the feature/fragment_manager_extensions branch February 6, 2018 08:48
@MGaetan89 MGaetan89 mentioned this pull request Feb 6, 2018
gmjgh added a commit to gmjgh/android-ktx that referenced this pull request Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants