Add forwarding player with simplified extension points that ensure consistency (e.g. ForwardingSimpleBasePlayer) #1183
Description
I have a similar issue to the one described here.
Based on the data I have in MediaMetadata I want to have control whether COMMAND_SEEK_TO_NEXT is available or not.
To reproduce issue from demo application, I altered data in catalog.json from demos/session_service and changed artist for few media items to empty strings in Electronic category. Then I wrapped ExoPlayer with ForwardingPlayer in DemoPlaybackService
val player = object : ForwardingPlayer(ExoPlayer.Builder(this)
.setAudioAttributes(AudioAttributes.DEFAULT, /* handleAudioFocus= */ true)
.build()
.apply {
addAnalyticsListener(EventLogger())
}) {
override fun getAvailableCommands(): Player.Commands {
return super.getAvailableCommands().buildUpon().apply {
if (currentMediaItem?.mediaMetadata?.artist?.isNotBlank() == true) {
add(COMMAND_SEEK_TO_NEXT)
} else {
remove(COMMAND_SEEK_TO_NEXT)
}
}.build()
}
override fun isCommandAvailable(command: Int): Boolean {
if (command == Player.COMMAND_SEEK_TO_NEXT) {
return currentMediaItem?.mediaMetadata?.artist?.isNotBlank() == true
}
return super.isCommandAvailable(command)
}
}
When I run the code, ExoPlayer in PlayerActivity displays that exo_next button is always available, even though when I click this button it sets some strange state in the player (no progress, old media item still plays).
But, when I add exactly the same code to the PlayerActivity
playerView.player = object : ForwardingPlayer(controller) {
override fun getAvailableCommands(): Player.Commands {
return super.getAvailableCommands().buildUpon().apply {
if (currentMediaItem?.mediaMetadata?.artist?.isNotBlank() == true) {
add(COMMAND_SEEK_TO_NEXT)
} else {
remove(COMMAND_SEEK_TO_NEXT)
}
}.build()
}
override fun isCommandAvailable(command: Int): Boolean {
if (command == Player.COMMAND_SEEK_TO_NEXT) {
return currentMediaItem?.mediaMetadata?.artist?.isNotBlank() == true
}
return super.isCommandAvailable(command)
}
}
exo_next button displays state correctly.
With this info I have few questions:
- Why does that happen? Shouldn't
MediaControllerrespect what's insideForwardingPlayerto be correctly shown in theplayerView.player? - Why media controller on the notification is still able to
seekToNext? This one is strange, because in my application overriding those methods in our implementation ofPlayerinterface is enough to control the behaviour of media notification. - How to wrap
ExoPlayerin only one place (service) to get it work correctly?