KEMBAR78
Mp3Extractor: Support files with (slightly) incorrectly declared ID3 tag lengths · Issue #811 · androidx/media · GitHub
Skip to content

Mp3Extractor: Support files with (slightly) incorrectly declared ID3 tag lengths #811

@Tolriq

Description

@Tolriq

Version

Media3 pre-release (alpha, beta or RC not in this list)

More version details

Any version but tested with 1.2.0

Devices that reproduce the issue

All

Devices that do not reproduce the issue

None

Reproducible in the demo app?

Yes

Reproduction steps

Try to play a file with multiple large ID3 headers.
Like a small ID3 v1 header followed by an ID3 header larger than 32k

The extractor sniff will fail because only the first ID3 header is taken in account and skipped, so the sniff does not reach the proper frames before the end of the second ID3 header.

Second header that should either be skipped or handled for the gapless data / metadata don't know if there should be a priorisation of ID3 v2 tags over v1 when both are present.

Expected result

The media should play

Actual result

The media does not play because the sniff return false due to large second ID3 header.

Media

I can send in private if necessary.

Bug Report

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions