fix(@angular/cli): correct query in find_examples to prevent runtime error

clydin · clydin · commit 431106559d6e · 2025-10-21T20:44:09.000-04:00
This commit fixes a runtime error in the `find_examples` tool that occurred when filtering examples. The error `no such column: experimental` was caused by an incorrect SQL query that attempted to access a column on the FTS virtual table (`examples_fts`) that only exists on the main content table (`examples`).

The fix refactors the database query to use a `JOIN` between the `examples` and `examples_fts` tables. This allows the `WHERE` clause to correctly filter on the `experimental` column from the main table while still leveraging the full-text search capabilities of the virtual table.
diff --git a/packages/angular/cli/src/commands/mcp/tools/examples.ts b/packages/angular/cli/src/commands/mcp/tools/examples.ts
@@ -339,11 +339,11 @@ function queryDatabase(db: DatabaseSync, input: FindExampleInput) {
   // Build the query dynamically
   const params: SQLInputValue[] = [];
   let sql =
-    'SELECT title, summary, keywords, required_packages, related_concepts, related_tools, content, ' +
+    `SELECT e.title, e.summary, e.keywords, e.required_packages, e.related_concepts, e.related_tools, e.content, ` +
     // The `snippet` function generates a contextual snippet of the matched text.
     // Column 6 is the `content` column. We highlight matches with asterisks and limit the snippet size.
     "snippet(examples_fts, 6, '**', '**', '...', 15) AS snippet " +
-    'FROM examples_fts';
+    'FROM examples e JOIN examples_fts ON e.id = examples_fts.rowid';
   const whereClauses = [];
 
   // FTS query
@@ -356,7 +356,7 @@ function queryDatabase(db: DatabaseSync, input: FindExampleInput) {
   const addJsonFilter = (column: string, values: string[] | undefined) => {
     if (values?.length) {
       for (const value of values) {
-        whereClauses.push(`${column} LIKE ?`);
+        whereClauses.push(`e.${column} LIKE ?`);
         params.push(`%"${value}"%`);
       }
     }
@@ -367,7 +367,7 @@ function queryDatabase(db: DatabaseSync, input: FindExampleInput) {
   addJsonFilter('related_concepts', related_concepts);
 
   if (!includeExperimental) {
-    whereClauses.push('experimental = 0');
+    whereClauses.push('e.experimental = 0');
   }
 
   if (whereClauses.length > 0) {
