KEMBAR78
Add Kubernetes Mesh Rule Support by AlbumenJ · Pull Request #8350 · apache/dubbo · GitHub
Skip to content

Conversation

@AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member Author

CRD file

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: virtualservices.service.dubbo.apache.org
spec:
  group: service.dubbo.apache.org
  versions:
    - name: v1alpha1
      served: true
      storage: true
      schema:
        openAPIV3Schema:
          type: object
          properties:
            spec:
              x-kubernetes-preserve-unknown-fields: true

  scope: Namespaced
  names:
    plural: virtualservices
    singular: virtualservice
    kind: VirtualService
    shortNames:
    - vs

---

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: destinationrules.service.dubbo.apache.org
spec:
  group: service.dubbo.apache.org
  versions:
    - name: v1alpha1
      served: true
      storage: true
      schema:
        openAPIV3Schema:
          type: object
          properties:
            spec:
              x-kubernetes-preserve-unknown-fields: true
   

  scope: Namespaced
  names:
    plural: destinationrules
    singular: destinationrule
    kind: DestinationRule
    shortNames:
    - dr

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2021

Codecov Report

Merging #8350 (b5e3f89) into 3.0 (94110c0) will decrease coverage by 0.09%.
The diff coverage is 29.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8350      +/-   ##
============================================
- Coverage     63.18%   63.09%   -0.10%     
- Complexity      311      313       +2     
============================================
  Files          1099     1102       +3     
  Lines         46057    46222     +165     
  Branches       6955     6975      +20     
============================================
+ Hits          29103    29165      +62     
- Misses        13700    13801     +101     
- Partials       3254     3256       +2     
Impacted Files Coverage Δ
...rpc/cluster/router/mesh/route/MeshEnvListener.java 0.00% <0.00%> (ø)
...registry/kubernetes/KubernetesMeshEnvListener.java 0.00% <0.00%> (ø)
...apache/dubbo/registry/kubernetes/MeshConstant.java 0.00% <0.00%> (ø)
...egistry/kubernetes/KubernetesServiceDiscovery.java 77.65% <50.00%> (-0.30%) ⬇️
...rpc/cluster/router/mesh/route/MeshRuleManager.java 75.00% <53.33%> (-15.00%) ⬇️
.../java/org/apache/dubbo/common/utils/PojoUtils.java 73.33% <77.08%> (+0.48%) ⬆️
...cluster/router/mesh/route/MeshAppRuleListener.java 83.78% <100.00%> (+0.45%) ⬆️
...ache/dubbo/config/utils/ConfigValidationUtils.java 74.32% <100.00%> (+0.30%) ⬆️
.../remoting/transport/netty4/NettyServerHandler.java 61.36% <0.00%> (-9.10%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94110c0...b5e3f89. Read the comment docs.

# Conflicts:
#	dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh/route/MeshRuleManager.java
@AlbumenJ AlbumenJ merged commit c125b99 into apache:3.0 Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants