KEMBAR78
feat(spec): Add schema types by Xuanwo · Pull Request #5 · apache/paimon-rust · GitHub
Skip to content

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 6, 2024

This PR will add schema types. The parse for DataType is not implemented yet.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from JingsongLi July 6, 2024 03:37
@Xuanwo Xuanwo changed the title feat(paimon/spec): Add schema types feat(spec): Add schema types Jul 6, 2024
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi
Copy link
Contributor

@Xuanwo Please resolve conflicts.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 8, 2024

@Xuanwo Please resolve conflicts.

Will do

Xuanwo added 2 commits July 8, 2024 12:18
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 8, 2024

DONE, @JingsongLi PTAL, thanks!

@JingsongLi
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit 6777f09 into apache:main Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants