fix(state): object mapper with input different #7435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome usage example! Might be good to document the test you're doing here as well? |
rvanlaak
reviewed
Oct 9, 2025
| { | ||
| $s = new self(); | ||
| $s->id = $data->id; | ||
| $s->username = $data->name; |
There was a problem hiding this comment.
This part (writing a value with a name different from it's input name) might only be possible since ObjectMapper's last patch release, and might break pre-7.3.4. Maybe cover this in the composer.json conflicts?
rvanlaak
reviewed
Oct 9, 2025
|
|
||
| namespace ApiPlatform\Tests\Fixtures\TestBundle\Dto; | ||
|
|
||
| class MappedResouceInput |
There was a problem hiding this comment.
Maybe also add a test where both these fields are required in the input's constructor, and with coverage on #[Assert\NotBlank] validation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: test