review comments

fandreuz · fandreuz · commit 568425b5c66d · 2025-08-12T12:06:09.000Z
diff --git a/src/converter/one/heatmap/Heatmap.java b/src/converter/one/heatmap/Heatmap.java
@@ -457,15 +457,15 @@ public void addStack(long id, long[] methods, int[] locations, byte[] types, int
             stackTracesCache.put(id, stackTracesRemap.index(cachedStackTrace, size));
         }
 
-        private Integer getMethodIndex(MethodKey key) {
+        private int getMethodIndex(MethodKey key) {
             Integer methodIdx = methodCache.get(key);
             if (methodIdx != null) return methodIdx;
             methodIdx = makeMethod(key);
             methodCache.put(key, methodIdx);
             return methodIdx;
         }
 
-        private Integer makeMethod(MethodKey key) {
+        private int makeMethod(MethodKey key) {
             return methods.index(key.makeMethod(converter, symbolTable));
         }
 
@@ -479,10 +479,9 @@ private static final class MethodKey {
             private final MethodKeyType keyType;
 
             public MethodKey(MethodKeyType keyType, long methodId, int location, byte type, boolean firstInStack) {
-                if (type < 0) throw new IllegalArgumentException("Unexpected type: " + type);
                 this.keyType = keyType;
                 this.methodId = methodId;
-                this.metadata = (long) (firstInStack ? 1 : 0) << 40 | (long) type << 32 | (location & 0xFFFFFFFFL);
+                this.metadata = (long) (firstInStack ? 1 : 0) << 40 | (type & 0xffL) << 32 | (location & 0xFFFFFFFFL);
             }
 
             public int getLocation() {
