review comments

fandreuz · fandreuz · commit e5e8d3312e13 · 2025-06-11T23:22:44.000+02:00
diff --git a/src/profiler.cpp b/src/profiler.cpp
@@ -31,7 +31,6 @@
 #include "frameName.h"
 #include "os.h"
 #include "otlp.h"
-#include "protobuf.h"
 #include "safeAccess.h"
 #include "stackFrame.h"
 #include "stackWalker.h"
diff --git a/src/protobuf.cpp b/src/protobuf.cpp
@@ -89,7 +89,7 @@ void ProtoBuffer::commitMessage(protobuf_mark_t mark) {
 
     for (size_t i = 0; i < max_len_byte_count - 1; ++i) {
         size_t idx = message_start + i;
-        _data[idx] = (unsigned char) (0x80 | (actual_len & 0x7f));
+        _data[idx] = 0x80 | (unsigned char)actual_len;
         actual_len >>= 7;
     }
     _data[message_start + max_len_byte_count - 1] = (unsigned char) actual_len;
diff --git a/src/protobuf.h b/src/protobuf.h
@@ -48,7 +48,7 @@ class ProtoBuffer {
     void field(protobuf_index_t index, const unsigned char* s, size_t len);
 
     protobuf_mark_t startMessage(protobuf_index_t index, size_t max_len_byte_count = NESTED_FIELD_BYTE_COUNT);
-    void commitMessage(const protobuf_mark_t& mark);
+    void commitMessage(protobuf_mark_t mark);
 
     void putVarInt(u64 n);
     static size_t varIntSize(u64 value);
