Implement search feature #1030
Closed
Implement search feature #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Press N to go to the next search result and Shift-N to go to the previous Search results are visited depth-first, visiting all results of a stack before moving on to the next stack on the right
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Press N to go to the next search result and Shift-N to go to the previous
Search results are visited depth-first, visiting all results of a stack before moving on to the next stack on the right.
This doesn't try to filter out any frames at all, so it is more intuitive how the next and previous works, at the cost of possibly navigating to more frames than neccesary.
Note: I only updated the demo
flamegraph htmlfor now, will update the actual one once the PR is finalised.Related issues
Motivation and context
This allows users to search for results that may be see when they are a low % of the samples.
How has this been tested?
This branch is built automatically to https://openorclose.github.io/async-profiler/demo/flamegraph.html for testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.