include asprof.h in async-profiler release #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krk
reviewed
Apr 24, 2025
| PACKAGE_NAME=async-profiler-$(PROFILER_VERSION)-$(OS_TAG)-$(ARCH_TAG) | ||
| PACKAGE_DIR=/tmp/$(PACKAGE_NAME) | ||
|
|
||
| ASPROF=bin/asprof |
There was a problem hiding this comment.
Let's update relevant documentation as well.
apangin
reviewed
Apr 24, 2025
Makefile
Outdated
| endif | ||
|
|
||
| build/$(ASPROF_HEADER): src/asprof.h | ||
| cp -f src/asprof.h $@ |
There was a problem hiding this comment.
Suggested change
| cp -f src/asprof.h $@ | |
| cp -f $< $@ |
fandreuz
reviewed
Apr 25, 2025
docs/ProfilingNonJavaApplications.md
Outdated
| Similar to the | ||
| [Java API](IntegratingAsyncProfiler.md#using-java-api), | ||
| there is a C API for using profiler inside a native application. | ||
| There is a C API for using profiler inside a native application. |
There was a problem hiding this comment.
I think the lowercase was right here, the sentence is not over yet
Signed-off-by: Bara' Hasheesh <bara.hasheesh@gmail.com>
apangin
reviewed
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in title
Related issues
N/A
Motivation and context
Make it more friendly for user to use async-profiler on C/C++ applications
How has this been tested?
make testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.