improve terminate logic in dwarf and vm stack walking mode #1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Alpine, we have seen cases where unwinding does not terminate properly (only terminates after we reach maxDepth value). This results in flamegraphs with a lot of "duplicate" frames. This happens because during unwinding, the next "pc" is always equal to current "pc" after a certain point.
In this PR, we add a check where we terminate the unwinding if
prev_sp == new_sp and prev_pc == new_pc.Related issues
N/A
How has this been tested?
Attached are before and after images of flame graphs for CPU profiling for this application in Alpine
Before
After
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.