Sample JVM method exit via bytecode rewriting #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fandreuz
changed the title
apangin
reviewed
Jul 31, 2025
apangin
reviewed
Jul 31, 2025
apangin
reviewed
Jul 31, 2025
apangin
reviewed
Jul 31, 2025
|
We're also missing |
apangin
reviewed
Aug 1, 2025
fandreuz
force-pushed
the
instrument-method-end
branch
from
bb14c68 to
579e2d6
Compare
fandreuz
force-pushed
the
instrument-method-end
branch
from
9a51a88 to
2cbfe2a
Compare
apangin
reviewed
Sep 5, 2025
src/instrument.cpp
Outdated
| const char* class_name; | ||
| const char* method_name; | ||
| int out = rewriteClass(&class_name, &method_name); | ||
| if (out == 0) { |
There was a problem hiding this comment.
Actually, I reverted this after 0f9931d, because this would cause some repetition where I handle errors
apangin
reviewed
Sep 5, 2025
src/instrument.cpp
Outdated
|
|
||
| constexpr u16 MAX_CODE_LENGTH = 65534; | ||
|
|
||
| enum { |
There was a problem hiding this comment.
Make it named enum and let functions return this type instead of int.
Constants no longer need to be negative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I enable recording JVM method exit via bytecode instrumentation. The bulk of this PR consists in:
I'm also adding a new parameter called
latency.latencyis absent, the previous behavior is keptlatencyis specified (can be 0) any execution of the method which exceedslatencyis going to record a sample.totalwill contain thedurationof the method execution.Related issues
n/a
Motivation and context
There are several use cases enabled by this PR:
How has this been tested?
New tests in
InstrumentTests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.