KEMBAR78

Add signal correlation API with thread-local buffer approach by adinazugravescu · Pull Request #1436 · async-profiler/async-profiler · GitHub

Add signal correlation API with thread-local buffer approach #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

adinazugravescu wants to merge 43 commits into async-profiler:master from adinazugravescu:signal-correlationv2

Contributor

adinazugravescu commented Aug 15, 2025

Description

Add API methods to correlate profiling samples with OpenTelemetry trace and span IDs.Not ready for review.

Related issues

N/A

Motivation and context

N/A

How has this been tested?

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

adinazugravescu added 15 commits

August 8, 2025 13:52


          Add signal correlation API for OTEL integration

a3866ac


          test: add OpenTelemetry signal correlation example

77e0451


          fixes for context id types

a7aeb1e


          Replace manual allocation with strdup

3751a64


          change context types

0c01267


          add trace ID and span ID frames

724f1dd


          add proto entries and change dumpOtlp

edda9c3


          fixes for dumpOtlp

ac14853


          fixes for writing link_table

a10f1fa


          delete : from link key

8391b45


          fixes for one frame


          fixes and remove test-otel

c9d518f


          fix number of frames in dumpOtlp

cb186ce


          fix proto index

68d1501


          Implement signal correlation with thread-local buffer approach

c03a716

fandreuz reviewed

View reviewed changes

src/api/one/profiler/TraceContext.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/api/one/profiler/TraceContext.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/profiler.cpp Outdated Show resolved Hide resolved


          fixes for writeString and add constexpr

6af74e1

fandreuz reviewed

View reviewed changes

src/api/one/profiler/TraceContext.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/profiler.cpp Outdated Show resolved Hide resolved


          fixes for writeString and add TODO

800f128

fandreuz reviewed

View reviewed changes

src/javaApi.cpp Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/api/one/profiler/TraceContext.java Outdated Show resolved Hide resolved


          name fix and identation

fandreuz reviewed

View reviewed changes

src/profiler.cpp Outdated Show resolved Hide resolved


          fix link index bug

b183f6f

fandreuz suggested changes

View reviewed changes

src/api/one/profiler/AsyncProfiler.java Outdated Show resolved Hide resolved

src/api/one/profiler/TraceContext.java Outdated Show resolved Hide resolved

src/api/one/profiler/TraceContext.java Outdated Show resolved Hide resolved

src/api/one/profiler/TraceContext.java Outdated Show resolved Hide resolved

src/api/one/profiler/TraceContext.java Outdated Show resolved Hide resolved

src/javaApi.cpp Outdated Show resolved Hide resolved

src/otlp.h Outdated Show resolved Hide resolved


          changed trace context buffer size

f1ef33f

fandreuz reviewed

View reviewed changes

src/api/one/profiler/TraceContext.java Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpTests.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationTest.java Show resolved Hide resolved

Adina Zugrvescu and others added 2 commits

August 29, 2025 15:28


          fixes for test files

c62d7d3


          use Dictionary

ee6c21f

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpTests.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationTest.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationTest.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationTest.java Outdated Show resolved Hide resolved


          added new condition for test

8641f6b

fandreuz mentioned this pull request

Expose profiler metrics via API #1460

Draft

fandreuz reviewed

View reviewed changes

src/arch.h Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/profiler.cpp Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/profiler.cpp Outdated Show resolved Hide resolved

Adina Zugrvescu added 2 commits

September 4, 2025 10:54


          design fixes


          Replace Dictionary with

a91a469

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationTest.java Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationTest.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/profiler.h Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/profiler.cpp Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/profiler.cpp Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

src/profiler.cpp Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpTests.java Show resolved Hide resolved

Adina Zugrvescu added 2 commits

September 24, 2025 10:09


          fixes + restart test added

2ec54c9


          fixed tests

c1a965a

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationWithRestartTest.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationWithRestartTest.java Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationWithRestartTest.java Outdated Show resolved Hide resolved

fandreuz reviewed

View reviewed changes

test/test/otlp/OtlpSignalCorrelationWithRestartTest.java

    
                      ProfilesData data = dumpAndGetProfile(profiler);

                      profiler.stop();

                      assert data.getDictionary().getLinkTableCount() == 1 : data.getDictionary().getLinkTableList().toString();

Contributor

fandreuz Sep 25, 2025

This is unexpected(?) Where is the link table coming from, since we restarted the profiler and the span context info is gone?

Contributor Author

adinazugravescu Sep 25, 2025

We should still have the empty link for samples without trace context

Contributor

fandreuz Sep 25, 2025

Right, thanks

fandreuz reviewed

View reviewed changes

src/profiler.cpp

    
              u64 Profiler::recordSample(void* ucontext, u64 counter, EventType event_type, Event* event) {

                  atomicInc(_total_samples);

                  if (_last_epoch != _epoch) {

Contributor

fandreuz Sep 25, 2025

I'm pretty sure this should be read with some level of synchronization, but you can leave it as it is for now.


          fixes for restart test

678052a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet