-
Notifications
You must be signed in to change notification settings - Fork 937
Add Liberica to the CI on Alpaquita musl #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What value does this particular configuration add? Do you know any errors that other configurations don't catch? |
Testing a commit that could potentially fail. |
Please see https://github.com/async-profiler/async-profiler/actions/runs/17581662920/job/49939353504?pr=1466 for failures about malloc tracer with the gcc version in alpaquita. |
All 4 failures are about
Looks like the same root cause as #1226 (comment), cannot sample Note that the |
@krk I've checked the issue here & the root cause for the failures is that on Alpaquita musl
We assume that if MUSL that Just change the |
It turns out that in this Alpaquita docker image musl is statically linked with mimalloc (!) which behaves differently from musl's built-in malloc implementation. So, it's not enough to check if the current process runs with glibc or musl, because libc itself can be built with an alternative implementation :-/ |
image: public.ecr.aws/bellsoft/alpaquita-linux-gcc:15.2-musl | ||
asprof-binaries-job: linux-x64 | ||
before-checkout: | | ||
apk add liberica21-jdk util-linux-misc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of installing these every time, wouldn't it be better to prepare an image with all the tools in place? That's what we do for other OS distributions.
This is especially relevant in the light of HTTP 504 failures during apk add
I saw in the previous runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do after #1502 is merged.
Force-pushed to resolve the conflict. |
Motivation and context
We can consider including more distributions in the GHA CI.
How has this been tested?
CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.