Expose dictionary that maps event id to javaThreadId #1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apangin
reviewed
Oct 6, 2025
| long javaThreadId = getVarlong(); | ||
| readFields(fieldCount - 4); | ||
| threads.put(id, javaName != null ? javaName : osName); | ||
| javaThreads.put(id, javaThreadId); |
There was a problem hiding this comment.
Micro-optimization: threads dictionary is pre-sized to the required capacity in the beginning of this method, so can javaThreads.
There was a problem hiding this comment.
Thanks for the quick review, good catch.
I see two options here:
Option 1: less change to existing code
int count = threads.preallocate(getVarint());
javaThreads.preallocate(count);
Option 2: IMHO a bit more self-explanatory in terms of what count is and what value we use to size the dicts.
int count = getVarint();
threads.preallocate(count);
javaThreads.preallocate(count);
Any preference between these two?
There was a problem hiding this comment.
Both are fine, but I agree Option 2 is a bit easier to understand.
There was a problem hiding this comment.
Went with option 2. Thanks again for the quick feedback.
Signed-off-by: Andrei Pangin <1749416+apangin@users.noreply.github.com>
|
Merged. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a dictionary
javaThreadsthat maps eventIds to javaThreadIds.Related issues
Fixes #1525
Motivation and context
For the sentry-java sdk we recently implemented continuous profiling with async-profiler. We had to vendor-in parts of the converter in order to get to the
Java Thread Idthat we need to map between profiles and transactions. This PR exposes that mapping and would allow us to simply use thejfr-converteras a dependency.Hopefully this will be useful for others too.
How has this been tested?
We implemented this change in sentry-java sdk and have tested it in that context.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.