Use VMStructs stack walking mode by default #1539
Merged
+31
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me The only comment I have is out of scope being it would properly be a good idea to prefer dwarf to FP when it's available on pure native apps |
…s fixed Signed-off-by: Andrei Pangin <1749416+apangin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
cstack=vmthe default stack walking mode on HotSpot JVM.Related issues
#1533
Motivation and context
We've been using
cstack=vmin production for a while and it proved stable.Recent changes (e.g. #1449, #1517, #1537) significantly improved quality of VMStructs stack traces, which is now superior to AsyncGetCallTrace. There are only advantages in using VMStructs, so it is a good time to change the defaults, thus making another step towards AsyncGetCallTrace deprecation.
How has this been tested?
All existing tests pass with no changes, except for
recoverytests that check soon-to-be-deprecatedsafemodeoption.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.