KEMBAR78
Add loglevel argument by luhenry · Pull Request #551 · async-profiler/async-profiler · GitHub
Skip to content

Conversation

@luhenry
Copy link
Contributor

@luhenry luhenry commented Feb 11, 2022

It allows to set the minimal log level to output. This is particularely
helpful if you're using async-profiler in production and where you don't
want to clubber your output with not always relevant log information.

@async-profiler async-profiler deleted a comment from toktarev Feb 11, 2022
Copy link
Member

@apangin apangin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. I like the idea of loglevel option.
Please find my comments inline.

It allows to set the minimal log level to output. This is particularely
helpful if you're using async-profiler in production and where you don't
want to clubber your output with not always relevant log information.
@apangin apangin merged commit ba00ca2 into async-profiler:master Feb 15, 2022
@apangin
Copy link
Member

apangin commented Feb 15, 2022

Thank you for the fixes; I merged the PR.
The new argument should be also mentioned in the list, but I'll just add it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants