-
Notifications
You must be signed in to change notification settings - Fork 406
Add de🐛 view for timings for Git operations (including queue times) #508
The head ref may contain hidden characters: "mkt-de\u{1F41B}-ui"
Conversation
@BinaryMuse Feel free to revert ☝️ , but thought it's kinda funny. |
@@ -1,22 +1,28 @@ | |||
@import "variables"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BinaryMuse Just FYI: If you want to use the theme variables you'll have to @import "variables";
which imports the ui-variables.less
. I think otherwise it will use the fallback variables from core, which could be off.
@simurai Thanks :) This will be a waterfall view soon enough |
💃 niiice. How would you feel about me refactoring this into timecop as a general tool at some point? You know, in my copious free time. Evolving the timecop package into a general-purpose set of performance monitoring and metrics visualization tools seems like a natural fit to me. |
Maybe! Especially if we find it brings values to a lot of users without bloating it too much. That's a ways off though; for now I'd prefer to iterate on the functionality here and see how it shakes out. |
dc3773d
to
c499e2d
Compare
Okay, the timings table has been converted into a waterfall view. This makes it easier to see how operations relate to each other. For example, in this case, the highlighted command ( There is also an import/export feature to allow capturing and sharing profiles: @simurai I did the best I could with the styling, but there's still an issue where the individual rows don't extend all the way to the right side of the container. You can see this in the Another designer and I looked at it for a while but weren't able to come up with anything. I'm sure my abundant usage of |
The goal is to implement a nice UI around this, but for now I'll just record some data and throw it in a table or something.
Resolves #507