KEMBAR78
Add de🐛 view for timings for Git operations (including queue times) by BinaryMuse · Pull Request #508 · atom/github · GitHub
Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

BinaryMuse
Copy link
Contributor

The goal is to implement a nice UI around this, but for now I'll just record some data and throw it in a table or something.

Resolves #507

@BinaryMuse BinaryMuse changed the title Add timings for Git operations (including queue times) Add de🐛 view for timings for Git operations (including queue times) Feb 8, 2017
@simurai
Copy link
Contributor

simurai commented Feb 8, 2017

Replace with 👾

@BinaryMuse Feel free to revert ☝️ , but thought it's kinda funny.

image

@@ -1,22 +1,28 @@
@import "variables";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BinaryMuse Just FYI: If you want to use the theme variables you'll have to @import "variables"; which imports the ui-variables.less. I think otherwise it will use the fallback variables from core, which could be off.

@simurai
Copy link
Contributor

simurai commented Feb 8, 2017

Any way to strip those "in + path". Or is that vital information?

screen shot 2017-02-08 at 7 31 00 pm

@BinaryMuse
Copy link
Contributor Author

@simurai Thanks :)

This will be a waterfall view soon enough

@smashwilson
Copy link
Contributor

💃 niiice.

How would you feel about me refactoring this into timecop as a general tool at some point? You know, in my copious free time. Evolving the timecop package into a general-purpose set of performance monitoring and metrics visualization tools seems like a natural fit to me.

@BinaryMuse
Copy link
Contributor Author

How would you feel about me refactoring this into timecop as a general tool at some point?

Maybe! Especially if we find it brings values to a lot of users without bloating it too much. That's a ways off though; for now I'd prefer to iterate on the functionality here and see how it shakes out.

@BinaryMuse BinaryMuse force-pushed the mkt-de branch 2 times, most recently from dc3773d to c499e2d Compare February 13, 2017 23:45
@BinaryMuse
Copy link
Contributor Author

Okay, the timings table has been converted into a waterfall view. This makes it easier to see how operations relate to each other.

For example, in this case, the highlighted command (git rev-parse --abbrev-ref HEAD) completed in just 15ms, but it was queued for more than 300ms:

fullscreen_2_13_17__5_04_pm

There is also an import/export feature to allow capturing and sharing profiles:

git-timings

@simurai I did the best I could with the styling, but there's still an issue where the individual rows don't extend all the way to the right side of the container. You can see this in the 2n+1 row background colors:

github_package_timings_view

Another designer and I looked at it for a while but weren't able to come up with anything. I'm sure my abundant usage of position: absolute is to blame.

@BinaryMuse BinaryMuse merged commit 2922a70 into master Feb 14, 2017
@BinaryMuse BinaryMuse deleted the mkt-de🐛-ui branch February 14, 2017 04:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants