This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Display the correct drag image on Electron >= 1.14 #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the cloned file name element (i.e. the element that is shown next to the cursor while dragging) is rendered on a separate GPU layer. This will prevent overlapping elements located at (0px, 0px) from being used as the drag image.
17 tasks
60 tasks
59 tasks
8 tasks
7 tasks
76 tasks
58 tasks
64 tasks
64 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: atom/atom#12696
This commit ensures that the cloned file name element (i.e. the element that is shown next to the cursor while dragging) is rendered on a separate GPU layer. This will prevent overlapping elements located at (0px, 0px) from being used as the drag image.
Before:
After:
/cc: @atom/maintainers