KEMBAR78
Pass boms during (unpinned) coursier fetch by joca-bt · Pull Request #1350 · bazel-contrib/rules_jvm_external · GitHub
Skip to content

Conversation

@joca-bt
Copy link
Contributor

@joca-bt joca-bt commented Apr 1, 2025

Addresses #1328.

I am unaware of what additional implications this might have so pinging the authors of the original maven resolver bom PR @shs96c @tirsen @cheister and of the coursier resolver bom PR @protocol7 for review.

@joca-bt joca-bt requested review from cheister, jin and shs96c as code owners April 1, 2025 15:56
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@joca-bt
Copy link
Contributor Author

joca-bt commented Apr 25, 2025

@shs96c is there a way I can retry the failed jobs? I'm not sure they are related to the change and I'm unable to run them locally.

(15:57:09) ERROR: C:/b/bk-windows-8slj/bazel/rules-jvm-external-examples/examples/kt_jvm_export/src/main/kotlin/com/github/bazelbuild/rulesjvmexternal/example/export/BUILD:3:15: KotlinCompile //src/main/kotlin/com/github/bazelbuild/rulesjvmexternal/example/export:export { kt: 1, java: 0, srcjars: 0 } for x64_windows failed: Worker process quit or closed its stdin stream when we tried to send a WorkRequest:

@joca-bt
Copy link
Contributor Author

joca-bt commented May 13, 2025

Would appreciate some help with the failing job, I can't reproduce it locally.

@shs96c
Copy link
Collaborator

shs96c commented May 14, 2025

This job appears to fail on every PR. I'm going to squash and merge this, and then figure out what's going on. Thank you for the PR!

@shs96c shs96c merged commit ffa1abd into bazel-contrib:master May 14, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants