KEMBAR78
Fix `Rails/CreateTableWithTimestamps` when using hash options by wata727 · Pull Request #5868 · rubocop/rubocop · GitHub
Skip to content

Conversation

wata727
Copy link
Contributor

@wata727 wata727 commented May 9, 2018

See also: #5503 (comment)

When using create_table with hash options, this Cop reports false positives.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

@wata727 wata727 force-pushed the fix_create_table_with_timestamps_false_positives branch from 9aadc1f to 0c612a7 Compare May 9, 2018 15:04
See also:
rubocop#5503 (comment)
When using `create_table` with hash options, this Cop reports
false positives.
@wata727 wata727 force-pushed the fix_create_table_with_timestamps_false_positives branch from 0c612a7 to bbc850d Compare May 9, 2018 15:11
@bbatsov bbatsov merged commit 6e9b2f3 into rubocop:master May 14, 2018
@bbatsov
Copy link
Collaborator

bbatsov commented May 14, 2018

👍

@wata727 wata727 deleted the fix_create_table_with_timestamps_false_positives branch June 6, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants