KEMBAR78
Fix support for node v0.8 support by kumavis · Pull Request #1939 · browserify/browserify · GitHub
Skip to content

Fix support for node v0.8 support #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 28, 2019
Merged

Fix support for node v0.8 support #1939

merged 3 commits into from
Dec 28, 2019

Conversation

@kumavis
Copy link
Contributor

@kumavis kumavis commented Dec 28, 2019 •
edited
Loading

@kumavis kumavis mentioned this pull request Dec 28, 2019
Merged
ljharb
ljharb reviewed Dec 28, 2019
View reviewed changes
kumavis and others added 2 commits December 28, 2019 11:44
@kumavis @ljharb
Update package.json
6c1fa0b 
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
@kumavis @ljharb
Update package.json
27391a4 
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
@ljharb ljharb added the bug label Dec 28, 2019
@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

I also noticed appveyor and travis tests dont have the same engine coverage...

@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

would be nice to document supported platforms for both browserify and bundles

@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

also if we could turn on greenkeeper for only in-range dep updates? would give us an idea if our deps break

@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

woof appveyor takes forever

@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

@ljharb finished cooking

@ljharb
Copy link
Member

ljharb commented Dec 28, 2019

We should definitely make sure “engines” is set correctly, as are CI matrices.

@ljharb ljharb merged commit b0e452c into browserify:master Dec 28, 2019
@kumavis kumavis deleted the fix-v0.8 branch December 28, 2019 04:46
@goto-bus-stop goto-bus-stop mentioned this pull request Jan 9, 2020
Closed
This was referenced Apr 21, 2020
Closed
Open
Merged
This was referenced May 2, 2020
Open
Open
Open
ghost
ghost reviewed Aug 2, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json###

@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Open
This was referenced May 29, 2021
Open
Open
Merged
Open
This was referenced Jun 6, 2021
Open
Closed
This was referenced Jun 6, 2021
Merged
Merged
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Closed
Closed
Open
Closed
@renovate renovate bot mentioned this pull request Jun 14, 2021
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 5, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 8, 2021
Open
1 task
@bee22193 bee22193 mentioned this pull request Jun 21, 2024
Open
@bee22193 bee22193 mentioned this pull request Jul 19, 2024
Open
@bee22193 bee22193 mentioned this pull request Aug 21, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
Open
This was referenced Sep 20, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kumavis @ljharb