[lint] switch to eslint

ljharb · ljharb · commit 89694cf7e406 · 2025-06-02T15:50:32.000-07:00
diff --git a/.eslintrc b/.eslintrc
@@ -0,0 +1,66 @@
+{
+	"root": true,
+
+	"extends": "@ljharb",
+
+	"globals": {
+		"Uint8Array": "readonly",
+		"Uint16Array": "readonly",
+		"Uint32Array": "readonly",
+		"Int8Array": "readonly",
+		"Int16Array": "readonly",
+		"Int32Array": "readonly",
+		"Float32Array": "readonly",
+		"Float64Array": "readonly",
+		"BigInt64Array": "readonly",
+		"BigUint64Array": "readonly",
+	},
+
+	"rules": {
+		"consistent-return": "warn",
+		"curly": "warn",
+		"dot-notation": [2, { "allowKeywords": true, "allowPattern": "throws" }],
+		"func-style": "warn",
+		"function-paren-newline": "warn",
+		"id-denylist": "warn",
+		"indent": ["error", 2],
+		"max-params": "warn",
+		"max-statements-per-line": "warn",
+		"multiline-comment-style": "off",
+		"no-else-return": "warn",
+		"no-extra-parens": "warn",
+		"no-param-reassign": "warn",
+		"no-use-before-define": "warn",
+		"semi": ["error", "never"],
+		"sort-keys": "warn",
+		"space-before-function-paren": "warn",
+		"strict": "warn",
+	},
+
+	"ignorePatterns": [
+		"test/bundle.js",
+	],
+
+	"overrides": [
+		{
+			"files": "bench/*",
+			"extends": "@ljharb/eslint-config/node/4",
+			"rules": {
+				"curly": "warn",
+				"func-style": "warn",
+				"indent": ["error", 2],
+				"max-params": "warn",
+				"no-extra-parens": "warn",
+				"no-mixed-operators": "warn",
+				"no-param-reassign": "warn",
+				"no-use-before-define": "warn",
+				"no-var": "off",
+				"prefer-arrow-callback": "off",
+				"prefer-template": "off",
+				"semi": ["error", "never"],
+				"space-before-function-paren": "warn",
+				"strict": "warn",
+			},
+		},
+	],
+}
diff --git a/index.js b/index.js
@@ -4,7 +4,7 @@ var checkParameters = require('./lib/precondition')
 var defaultEncoding = require('./lib/default-encoding')
 var toBuffer = require('./lib/to-buffer')
 
-function nativePBKDF2 (password, salt, iterations, keylen, digest, callback) {
+function nativePBKDF2(password, salt, iterations, keylen, digest, callback) {
   checkParameters(iterations, keylen)
   password = toBuffer(password, defaultEncoding, 'Password')
   salt = toBuffer(salt, defaultEncoding, 'Salt')
@@ -13,12 +13,12 @@ function nativePBKDF2 (password, salt, iterations, keylen, digest, callback) {
     callback = digest
     digest = 'sha1'
   }
-  if (typeof callback !== 'function') throw new Error('No callback provided to pbkdf2')
+  if (typeof callback !== 'function') { throw new Error('No callback provided to pbkdf2') }
 
   return native.pbkdf2(password, salt, iterations, keylen, digest, callback)
 }
 
-function nativePBKDF2Sync (password, salt, iterations, keylen, digest) {
+function nativePBKDF2Sync(password, salt, iterations, keylen, digest) {
   checkParameters(iterations, keylen)
   password = toBuffer(password, defaultEncoding, 'Password')
   salt = toBuffer(salt, defaultEncoding, 'Salt')
@@ -28,6 +28,7 @@ function nativePBKDF2Sync (password, salt, iterations, keylen, digest) {
 
 /* istanbul ignore next */
 if (!native.pbkdf2Sync || native.pbkdf2Sync.toString().indexOf('keylen, digest') === -1) {
+  /* eslint global-require: 0 */
   exports.pbkdf2Sync = require('./lib/sync')
   exports.pbkdf2 = require('./lib/async')
 
diff --git a/package.json b/package.json
@@ -33,17 +33,19 @@
     "coverage-report": "nyc report --reporter=lcov",
     "coverage-html": "nyc report --reporter=html",
     "coverage": "nyc --check-coverage --branches 95 --functions 95 tape test/*.js",
-    "lint": "standard",
-    "test": "npm run lint && npm run unit",
+    "lint": "eslint --ext=js,mjs .",
+    "pretest": "npm run lint",
+    "tests-only": "tape test/*.js",
+    "test": "npm run tests-only",
     "bundle-test": "browserify test/index.js > test/bundle.js",
-    "unit": "tape test/*.js",
     "bench": "node bench/"
   },
   "devDependencies": {
+    "@ljharb/eslint-config": "^21.1.1",
     "benchmark": "^2.1.4",
     "browserify": "*",
+    "eslint": "=8.8.0",
     "nyc": "^6.4.0",
-    "standard": "*",
     "tape": "^4.5.1"
   },
   "dependencies": {
@@ -53,11 +55,6 @@
     "safe-buffer": "^5.0.1",
     "sha.js": "^2.4.8"
   },
-  "standard": {
-    "ignore": [
-      "test/bundle.js"
-    ]
-  },
   "engines": {
     "node": ">=0.12"
   },
diff --git a/test/index.js b/test/index.js
@@ -76,7 +76,7 @@ if (pVersionMajor >= 6 || process.browser) {
   })
 }
 
-function runTests (name, compat) {
+function runTests(name, compat) {
   tape(name + ' defaults to sha1 and handles buffers', function (t) {
     t.plan(3)
 
@@ -183,7 +183,7 @@ function runTests (name, compat) {
       tape(name + ' async w/ ' + description, function (t) {
         t.plan(1)
         /* istanbul ignore next */
-        function noop () {}
+        function noop() {}
         t.throws(function () {
           compat.pbkdf2(f.key, f.salt, f.iterations, f.dkLen, f.algo, noop)
         }, new RegExp(f.exception))
@@ -205,6 +205,7 @@ runTests('JavaScript pbkdf2', js)
 
 /* istanbul ignore next */
 if (!process.browser) {
+  /* eslint global-require: 0 */
   var browser = Object.assign({}, js)
   browser.pbkdf2Sync = require('../lib/sync-browser')
   runTests('browser pbkdf2', {
