Add non-local PR template support #5097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcoe
commented
Jan 25, 2022
Comment on lines
-208
to
-211
| m.templates = make([]Template, len(issueTemplates)) | ||
| for i := range issueTemplates { | ||
| m.templates[i] = &issueTemplates[i] | ||
| } |
There was a problem hiding this comment.
I moved this work into the list functions so that they would both have the same function signatures.
mislav
suggested changes
Jan 25, 2022
pkg/cmd/pr/shared/templates.go
Outdated
| return hasQuerySupport && hasMutationSupport, nil | ||
| } | ||
|
|
||
| func hasPullRequestTemplateSupport(httpClient *http.Client, hostname string) (bool, error) { |
There was a problem hiding this comment.
This function does the exact same query as hasIssueTemplateSupport, except that it scans for a different field on a Repository object. Could this lookup instead piggyback on hasIssueTemplateSupport so that fewer API calls are done?
There was a problem hiding this comment.
Yup good call. I consolidated hasIssueTemplateSupport and hasPullRequestTemplateSupport into a single hasTemplateSupport function which uses one query and supports both issues and pull requests.
mislav
approved these changes
Jan 28, 2022
|
Thank you, @samcoe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use non-local templates when opening a PR. It is mostly a copy of the work done for issue create templates.
Closes #838