Add base gh pr view acceptance tests for changes

These are acceptance tests based on @williammartin work within various issues associated with #9208. These need to be enhanced to account for `gh pr status`, however that should be quicker given these pass based on the updated branch and upstream fix for cross-repo same org changes.
cli · jtmcg · Jan 29, 2025 · Jun 14, 2024 · Jun 14, 2024 · Jun 14, 2024
commit 2d1e4d625bc2a31c61c70452388188b327032b3c
diff --git a/acceptance/testdata/pr/pr-view-respects-branch-pushremote.txtar b/acceptance/testdata/pr/pr-view-respects-branch-pushremote.txtar
@@ -0,0 +1,42 @@
+# Setup environment variables used for testscript
+env REPO=${SCRIPT_NAME}-${RANDOM_STRING}
+env FORK=${REPO}-fork
+
+# Use gh as a credential helper
+exec gh auth setup-git
+
+# Create a repository to act as upstream with a file so it has a default branch
+exec gh repo create ${ORG}/${REPO} --add-readme --private
+
+# Defer repo cleanup of upstream
+defer gh repo delete --yes ${ORG}/${REPO}
+exec gh repo view ${ORG}/${REPO} --json id --jq '.id'
+stdout2env REPO_ID
+
+# Create a user fork of repository as opposed to private organization fork
+exec gh repo fork ${ORG}/${REPO} --org ${ORG} --fork-name ${FORK}
+
+# Defer repo cleanup of fork
+defer gh repo delete --yes ${ORG}/${FORK}
+sleep 5
+exec gh repo view ${ORG}/${FORK} --json id --jq '.id'
+stdout2env FORK_ID
+
+# Clone the repo
+exec gh repo clone ${ORG}/${FORK}
+cd ${FORK}
+
+# Prepare a branch where changes are pulled from the upstream default branch but pushed to fork
+exec git checkout -b feature-branch upstream/main
+exec git config branch.feature-branch.pushRemote origin
+exec git config --list
+exec git commit --allow-empty -m 'Empty Commit'
+exec git push
+
+# Create the PR spanning upstream and fork repositories, gh pr create does not support headRepositoryId needed for private forks
+exec gh api graphql -F repositoryId="${REPO_ID}" -F headRepositoryId="${FORK_ID}" -F query='mutation CreatePullRequest($headRepositoryId: ID!, $repositoryId: ID!) { createPullRequest(input:{ baseRefName: "main", body: "Feature Body", draft: false, headRefName: "feature-branch", headRepositoryId: $headRepositoryId, repositoryId: $repositoryId, title:"Feature Title" }){ pullRequest{ id url } } }'
+
+# View the PR
+env GH_DEBUG=api
+exec gh pr view
+stdout 'Feature Title'
diff --git a/acceptance/testdata/pr/pr-view-respects-push-destination.txtar b/acceptance/testdata/pr/pr-view-respects-push-destination.txtar
@@ -0,0 +1,33 @@
+# Setup environment variables used for testscript
+env REPO=${SCRIPT_NAME}-${RANDOM_STRING}
+
+# Use gh as a credential helper
+exec gh auth setup-git
+
+# Create a repository with a file so it has a default branch
+exec gh repo create ${ORG}/${REPO} --add-readme --private
+
+# Defer repo cleanup
+defer gh repo delete --yes ${ORG}/${REPO}
+
+# Clone the repo
+exec gh repo clone ${ORG}/${REPO}
+cd ${REPO}
+
+# Configure default push behavior so local and remote branches will be the same
+exec git config push.default current
+
+# Prepare a branch where changes are pulled from the default branch instead of remote branch of same name
+exec git checkout -b test-feature
+exec git branch --set-upstream-to origin/main
+exec git rev-parse --abbrev-ref test-feature@{upstream}
+stdout origin/main
+
+# Create the PR
+exec git commit --allow-empty -m 'Empty Commit'
+exec git push
+exec gh pr create -B main -H test-feature --title 'Feature Title' --body 'Feature Body'
+
+# View the PR
+exec gh pr view
+stdout 'Feature Title'
diff --git a/acceptance/testdata/pr/pr-view-respects-remote-pushdefault.txtar b/acceptance/testdata/pr/pr-view-respects-remote-pushdefault.txtar
@@ -0,0 +1,42 @@
+# Setup environment variables used for testscript
+env REPO=${SCRIPT_NAME}-${RANDOM_STRING}
+env FORK=${REPO}-fork
+
+# Use gh as a credential helper
+exec gh auth setup-git
+
+# Create a repository to act as upstream with a file so it has a default branch
+exec gh repo create ${ORG}/${REPO} --add-readme --private
+
+# Defer repo cleanup of upstream
+defer gh repo delete --yes ${ORG}/${REPO}
+exec gh repo view ${ORG}/${REPO} --json id --jq '.id'
+stdout2env REPO_ID
+
+# Create a user fork of repository as opposed to private organization fork
+exec gh repo fork ${ORG}/${REPO} --org ${ORG} --fork-name ${FORK}
+
+# Defer repo cleanup of fork
+defer gh repo delete --yes ${ORG}/${FORK}
+sleep 5
+exec gh repo view ${ORG}/${FORK} --json id --jq '.id'
+stdout2env FORK_ID
+
+# Clone the repo
+exec gh repo clone ${ORG}/${FORK}
+cd ${FORK}
+
+# Prepare a branch where changes are pulled from the upstream default branch but pushed to fork
+exec git checkout -b feature-branch upstream/main
+exec git config remote.pushDefault origin
+exec git config --list
+exec git commit --allow-empty -m 'Empty Commit'
+exec git push
+
+# Create the PR spanning upstream and fork repositories, gh pr create does not support headRepositoryId needed for private forks
+exec gh api graphql -F repositoryId="${REPO_ID}" -F headRepositoryId="${FORK_ID}" -F query='mutation CreatePullRequest($headRepositoryId: ID!, $repositoryId: ID!) { createPullRequest(input:{ baseRefName: "main", body: "Feature Body", draft: false, headRefName: "feature-branch", headRepositoryId: $headRepositoryId, repositoryId: $repositoryId, title:"Feature Title" }){ pullRequest{ id url } } }'
+
+# View the PR
+env GH_DEBUG=api
+exec gh pr view
+stdout 'Feature Title'
diff --git a/acceptance/testdata/pr/pr-view-respects-simple-pushdefault.txtar b/acceptance/testdata/pr/pr-view-respects-simple-pushdefault.txtar
@@ -0,0 +1,30 @@
+# Setup environment variables used for testscript
+env REPO=${SCRIPT_NAME}-${RANDOM_STRING}
+
+# Use gh as a credential helper
+exec gh auth setup-git
+
+# Create a repository with a file so it has a default branch
+exec gh repo create ${ORG}/${REPO} --add-readme --private
+
+# Defer repo cleanup
+defer gh repo delete --yes ${ORG}/${REPO}
+
+# Clone the repo
+exec gh repo clone ${ORG}/${REPO}
+cd ${REPO}
+
+# Configure default push behavior so local and remote branches have to be the same
+exec git config push.default simple
+
+# Prepare a branch where changes are pulled from the default branch instead of remote branch of same name
+exec git checkout -b test-feature origin/main
+
+# Create the PR
+exec git commit --allow-empty -m 'Empty Commit'
+exec git push origin test-feature
+exec gh pr create -H test-feature --title 'Feature Title' --body 'Feature Body'
+
+# View the PR
+exec gh pr view
+stdout 'Feature Title'