load container image into local store during build (#11000)

jonboulle · web-flow · commit a6de9db65185 · 2025-10-17T18:11:23.000+01:00
* load container image into local store during build BuildKit supports different [build drivers](https://docs.docker.com/build/builders/drivers/). When using the more modern `docker-container` driver (which is now the default on some systems, e.g. a standard Docker installation on Fedora Linux), it will not automatically load the built image into the local image store. Since wrangler expects the image to be there (e.g. when calling `getImageRepoTags`), it will thus fail, e.g.: ``` ⎔ Preparing container image(s)... [+] Building 0.3s (8/8) FINISHED docker-container:default [...] WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load ✘ [ERROR] failed inspecting image locally: Error response from daemon: failed to find image cloudflare-dev/sandbox:f86e40e4: docker.io/cloudflare-dev/sandbox:f86e40e4: No such image ``` Explicitly setting the `--load` flag (equivalent to `-o type=docker`) during the build fixes this and should make the build a bit more portable without requiring users to change their default build driver configuration. * fix tests * fix more tests
diff --git a/.changeset/green-dancers-sin.md b/.changeset/green-dancers-sin.md
@@ -0,0 +1,23 @@
+---
+"@cloudflare/containers-shared": patch
+"wrangler": patch
+---
+
+always load container image into local store during build
+
+
+BuildKit supports different [build drivers](https://docs.docker.com/build/builders/drivers/). When using the more modern `docker-container` driver (which is now the default on some systems, e.g. a standard Docker installation on Fedora Linux), it will not automatically load the built image into the local image store. Since wrangler expects the image to be there (e.g. when calling `getImageRepoTags`), it will thus fail, e.g.:
+
+```
+⎔ Preparing container image(s)...
+[+] Building 0.3s (8/8) FINISHED                                                                                                                                                                                                     docker-container:default
+
+[...]
+
+WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
+
+✘ [ERROR] failed inspecting image locally: Error response from daemon: failed to find image cloudflare-dev/sandbox:f86e40e4: docker.io/cloudflare-dev/sandbox:f86e40e4: No such image
+
+```
+
+Explicitly setting the `--load` flag (equivalent to `-o type=docker`) during the build fixes this and should make the build a bit more portable without requiring users to change their default build driver configuration.
diff --git a/packages/containers-shared/src/build.ts b/packages/containers-shared/src/build.ts
@@ -15,6 +15,7 @@ export async function constructBuildCommand(
 	const platform = options.platform ?? "linux/amd64";
 	const buildCmd = [
 		"build",
+		"--load",
 		"-t",
 		options.tag,
 		"--platform",
diff --git a/packages/wrangler/src/__tests__/cloudchamber/build.test.ts b/packages/wrangler/src/__tests__/cloudchamber/build.test.ts
@@ -60,6 +60,7 @@ describe("buildAndMaybePush", () => {
 		expect(dockerBuild).toHaveBeenCalledWith("docker", {
 			buildCmd: [
 				"build",
+				"--load",
 				"-t",
 				`test-app:tag`,
 				"--platform",
@@ -104,6 +105,7 @@ describe("buildAndMaybePush", () => {
 		expect(dockerBuild).toHaveBeenCalledWith("docker", {
 			buildCmd: [
 				"build",
+				"--load",
 				"-t",
 				`registry.cloudflare.com/test-app:tag`,
 				"--platform",
@@ -147,6 +149,7 @@ describe("buildAndMaybePush", () => {
 		expect(dockerBuild).toHaveBeenCalledWith("docker", {
 			buildCmd: [
 				"build",
+				"--load",
 				"-t",
 				`registry.cloudflare.com/some-account-id/test-app:tag`,
 				"--platform",
@@ -191,6 +194,7 @@ describe("buildAndMaybePush", () => {
 		expect(dockerBuild).toHaveBeenCalledWith("/custom/docker/path", {
 			buildCmd: [
 				"build",
+				"--load",
 				"-t",
 				`test-app:tag`,
 				"--platform",
@@ -235,6 +239,7 @@ describe("buildAndMaybePush", () => {
 		expect(dockerBuild).toHaveBeenCalledWith("docker", {
 			buildCmd: [
 				"build",
+				"--load",
 				"-t",
 				`test-app:tag`,
 				"--platform",
@@ -293,6 +298,7 @@ describe("buildAndMaybePush", () => {
 		expect(dockerBuild).toHaveBeenCalledWith("docker", {
 			buildCmd: [
 				"build",
+				"--load",
 				"-t",
 				`test-app:tag`,
 				"--platform",
@@ -329,6 +335,7 @@ describe("buildAndMaybePush", () => {
 		expect(dockerBuild).toHaveBeenCalledWith("docker", {
 			buildCmd: [
 				"build",
+				"--load",
 				"-t",
 				`test-app`,
 				"--platform",
@@ -351,6 +358,7 @@ describe("buildAndMaybePush", () => {
 		expect(dockerBuild).toHaveBeenCalledWith("docker", {
 			buildCmd: [
 				"build",
+				"--load",
 				"-t",
 				`test-app`,
 				"--platform",
@@ -373,6 +381,7 @@ describe("buildAndMaybePush", () => {
 		expect(dockerBuild).toHaveBeenCalledWith("docker", {
 			buildCmd: [
 				"build",
+				"--load",
 				"-t",
 				`test-app:tag`,
 				"--platform",
diff --git a/packages/wrangler/src/__tests__/containers/deploy.test.ts b/packages/wrangler/src/__tests__/containers/deploy.test.ts
@@ -2107,6 +2107,7 @@ function mockDockerBuild(
 		expect(cmd).toBe("/usr/bin/docker");
 		expect(args).toEqual([
 			"build",
+			"--load",
 			"-t",
 			`${containerName}:${tag}`,
 			"--platform",
