Set default values when statically replacing process.env.NODE_ENV
#11027
+346
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f181512 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jamesopstad
force-pushed
the
james/default-process-env
branch
2 times, most recently
from
db2eef5 to
2d8c56f
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
vicb
reviewed
Oct 20, 2025
vicb
reviewed
Oct 20, 2025
vicb
reviewed
Oct 20, 2025
vicb
approved these changes
Oct 20, 2025
jamesopstad
force-pushed
the
james/default-process-env
branch
2 times, most recently
from
36105c6 to
797f68d
Compare
jamesopstad
force-pushed
the
james/default-process-env
branch
from
797f68d to
f181512
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10983.
Fixes #10984.
Fixes #9802.
Fixes #7886.
Statically replace the value of
process.env.NODE_ENVwithdevelopmentfor development builds andproductionfor production builds if it is not set. Else, use the given value. This ensures that libraries, such as React, that branch code based onprocess.env.NODE_ENVcan be properly tree shaken.Note that this effectively duplicates the logic we already have in the Vite plugin