🦋 Changeset detected

Latest commit: 615ca52

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

npm i https://pkg.pr.new/create-cloudflare@9705

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9705

npm i https://pkg.pr.new/miniflare@9705

npm i https://pkg.pr.new/@cloudflare/pages-shared@9705

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9705

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9705

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9705

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9705

npm i https://pkg.pr.new/wrangler@9705

commit: 615ca52

@sidharthachatterjee could you take a look at this?

Thanks @penalosa

@LuisDuarte1 from the Workflows team will be reviewing this, cheers

@LuisDuarte1 Got it. Just one more thing, since we have no access to workerd/worker.mjs afaik, is it acceptable for me to add the utility type to the type-generation?

@LuisDuarte1 @penalosa just recently started using workflows and this PR would be a nice improvement.

Well, if workerd/worker.mjs is not really meant to be touched, I'm happy to move the utility type to the generated output. Just think workerd/worker.mjs suits better though.

@penalosa can we get this in (after rebase)?

@LuisDuarte1 are there concerns with the approach here?

@LuisDuarte1 are there concerns with the approach here?

Would prefer to somehow hide the .['run']>[0]['payload']> part because that seems a bit verbose. But it's non-blocking and can be improved later.

@hiendv in order to add the type helper, you'd have to make a PR to workerd modifying the workflows type definitions: https://github.com/cloudflare/workerd/blob/main/types/defines/workflows.d.ts. I'd be happy to review and get that released if you open one!

OK so I took a look at workerd and it seems more complicated than anticipated.
This is my proposal

1. workerd/types/defines/rpd.d.ts (yes, not workflow.d.ts because WorkflowEntrypoint belongs here)

// After export abstract class WorkflowEntrypoint
type AnyWorkflowEntrypoint = new (...args: any) => WorkflowEntrypoint;
export type WorkflowPayload<T extends AnyWorkflowEntrypoint> = InstanceType<T> extends WorkflowEntrypoint<unknown, infer P> ? P : never;

2. type-generation

interface Env {
		MY_WORKFLOW: Workflow<import('cloudflare:workers').WorkflowPayload<typeof import("./src/index").MyWorkflow>>;
	}

Doesn't seem better because of the import('cloudflare:workers'), to be honest. What do you think?

2. type-generation

interface Env {
		MY_WORKFLOW: Workflow<import('cloudflare:workers').WorkflowPayload<typeof import("./src/index").MyWorkflow>>;
	}

Doesn't seem better because of the import('cloudflare:workers'), to be honest. What do you think?

Lol, pipeline looks messy as well 😆

import("cloudflare:pipelines").Pipeline<import("cloudflare:pipelines").PipelineRecord>;

Congratulations @hiendv, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmgs02iqy00c4l504gr4ixtz4

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!