KEMBAR78
Comparing v1.5.2...v1.5.3 · coffeelint/coffeelint · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coffeelint/coffeelint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.5.2
Choose a base ref
...
head repository: coffeelint/coffeelint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.5.3
Choose a head ref
  • 16 commits
  • 28 files changed
  • 4 contributors

Commits on Jun 8, 2014

  1. Actually check indentation for chained calls.

    The previous PR only addressed the INDENT tokens, this addresses the
    issue of the chained calls being properly indented.
    swang committed Jun 8, 2014
    Configuration menu
    Copy the full SHA
    2f7eb8d View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2014

  1. Merge pull request #285 from swang/check_indents_on_dots

    Actually check indentation for chained calls.
    AsaAyers committed Jun 13, 2014
    Configuration menu
    Copy the full SHA
    aa129c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2014

  1. Configuration menu
    Copy the full SHA
    461d52d View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2014

  1. Fix implicit parens edge-case (for last line)

    This is an attempt at fixing #302. Basically if you have strict set to
    false as part of the no_implicit_parens config, it should allow implicit
    parens when it's done across multiple lines.
    
    Before the change was done by detecting for a newline. Unfortunately it
    seems that CoffeeScript does not add a newline property so you can have
    implicit parens on the last line of code.
    swang committed Jul 20, 2014
    Configuration menu
    Copy the full SHA
    051d2b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2014

  1. Fixes method chaining looking out of scope

    This PR is a rewrite of the original code that was used to generate the
    correct INDENT value for INDENT tokens when a user wrote code that used
    method chaining with each new method on it's own particular line.
    
    There is less redundant code, with a new function called
    `getCorrectIndent` that will return the corrected INDENT value that
    should be there instead of what CoffeeScript original generates.
    
    This also fixes #305 where the original `isChainedCall` function was
    looking out of its scope when checking for proper indenting in the
    current method chain.
    swang committed Jul 27, 2014
    Configuration menu
    Copy the full SHA
    9376542 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #306 from swang/fixed_method_chaining_bug

    Fixes method chaining looking out of scope
    AsaAyers committed Jul 27, 2014
    Configuration menu
    Copy the full SHA
    acddfd5 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #303 from swang/fix_edge_case_for_parens

    Fix implicit parens edge-case (for last line)
    AsaAyers committed Jul 27, 2014
    Configuration menu
    Copy the full SHA
    869f6ac View commit details
    Browse the repository at this point in the history
  4. Add rules folder as part of the linting process

    This includes the src/rules folder as part of the linting process for
    the library. This means that when you run `npm test` it will now also
    lint src/rules.
    
    Also fixes errors being generated from CoffeeScript files in the rules
    folder.
    
    Note there are now 2 more warnings for cyclomatic complexity.
    swang committed Jul 27, 2014
    Configuration menu
    Copy the full SHA
    805c499 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2014

  1. Merge pull request #307 from swang/lint_the_rules

    Add rules folder as part of the linting process
    AsaAyers committed Jul 28, 2014
    Configuration menu
    Copy the full SHA
    21020f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2014

  1. Fixes #309

    AsaAyers committed Aug 5, 2014
    Configuration menu
    Copy the full SHA
    17cc530 View commit details
    Browse the repository at this point in the history
  2. Include the test for #306

    AsaAyers committed Aug 5, 2014
    Configuration menu
    Copy the full SHA
    50ac18d View commit details
    Browse the repository at this point in the history
  3. Merge pull request #297 from paulcollinsiii/space_operator_fixes

    Space_operators missed some cases
    AsaAyers committed Aug 5, 2014
    Configuration menu
    Copy the full SHA
    4738cc5 View commit details
    Browse the repository at this point in the history
  4. Fix long line

    AsaAyers committed Aug 5, 2014
    Configuration menu
    Copy the full SHA
    98c7580 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2014

  1. Fix an edgecase bug for no_trailing_semicolons

    This is to fix an edge case bug where, inside of a multiline string,
    there is an interpolated string where the entire interpolation is a
    function call and does not contain a variable/string.
    
    Fixes #314
    swang committed Aug 8, 2014
    Configuration menu
    Copy the full SHA
    b9399ce View commit details
    Browse the repository at this point in the history
  2. Merge pull request #315 from swang/fix_edgecase_for_no_trailing_semic…

    …olons
    
    Fix an edgecase bug for no_trailing_semicolons
    AsaAyers committed Aug 8, 2014
    Configuration menu
    Copy the full SHA
    d8c5fbb View commit details
    Browse the repository at this point in the history
  3. 1.5.3

    AsaAyers committed Aug 8, 2014
    Configuration menu
    Copy the full SHA
    5ae1425 View commit details
    Browse the repository at this point in the history
Loading