-
Notifications
You must be signed in to change notification settings - Fork 12
Comparing changes
Open a pull request
base repository: coffeelint/coffeelint
base: v1.5.2
head repository: coffeelint/coffeelint
compare: v1.5.3
- 16 commits
- 28 files changed
- 4 contributors
Commits on Jun 8, 2014
-
Actually check indentation for chained calls.
The previous PR only addressed the INDENT tokens, this addresses the issue of the chained calls being properly indented.
Configuration menu - View commit details
-
Copy full SHA for 2f7eb8d - Browse repository at this point
Copy the full SHA 2f7eb8dView commit details
Commits on Jun 13, 2014
-
Merge pull request #285 from swang/check_indents_on_dots
Actually check indentation for chained calls.
Configuration menu - View commit details
-
Copy full SHA for aa129c1 - Browse repository at this point
Copy the full SHA aa129c1View commit details
Commits on Jul 4, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 461d52d - Browse repository at this point
Copy the full SHA 461d52dView commit details
Commits on Jul 20, 2014
-
Fix implicit parens edge-case (for last line)
This is an attempt at fixing #302. Basically if you have strict set to false as part of the no_implicit_parens config, it should allow implicit parens when it's done across multiple lines. Before the change was done by detecting for a newline. Unfortunately it seems that CoffeeScript does not add a newline property so you can have implicit parens on the last line of code.
Configuration menu - View commit details
-
Copy full SHA for 051d2b0 - Browse repository at this point
Copy the full SHA 051d2b0View commit details
Commits on Jul 27, 2014
-
Fixes method chaining looking out of scope
This PR is a rewrite of the original code that was used to generate the correct INDENT value for INDENT tokens when a user wrote code that used method chaining with each new method on it's own particular line. There is less redundant code, with a new function called `getCorrectIndent` that will return the corrected INDENT value that should be there instead of what CoffeeScript original generates. This also fixes #305 where the original `isChainedCall` function was looking out of its scope when checking for proper indenting in the current method chain.
Configuration menu - View commit details
-
Copy full SHA for 9376542 - Browse repository at this point
Copy the full SHA 9376542View commit details -
Merge pull request #306 from swang/fixed_method_chaining_bug
Fixes method chaining looking out of scope
Configuration menu - View commit details
-
Copy full SHA for acddfd5 - Browse repository at this point
Copy the full SHA acddfd5View commit details -
Merge pull request #303 from swang/fix_edge_case_for_parens
Fix implicit parens edge-case (for last line)
Configuration menu - View commit details
-
Copy full SHA for 869f6ac - Browse repository at this point
Copy the full SHA 869f6acView commit details -
Add rules folder as part of the linting process
This includes the src/rules folder as part of the linting process for the library. This means that when you run `npm test` it will now also lint src/rules. Also fixes errors being generated from CoffeeScript files in the rules folder. Note there are now 2 more warnings for cyclomatic complexity.
Configuration menu - View commit details
-
Copy full SHA for 805c499 - Browse repository at this point
Copy the full SHA 805c499View commit details
Commits on Jul 28, 2014
-
Merge pull request #307 from swang/lint_the_rules
Add rules folder as part of the linting process
Configuration menu - View commit details
-
Copy full SHA for 21020f1 - Browse repository at this point
Copy the full SHA 21020f1View commit details
Commits on Aug 5, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 17cc530 - Browse repository at this point
Copy the full SHA 17cc530View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50ac18d - Browse repository at this point
Copy the full SHA 50ac18dView commit details -
Merge pull request #297 from paulcollinsiii/space_operator_fixes
Space_operators missed some cases
Configuration menu - View commit details
-
Copy full SHA for 4738cc5 - Browse repository at this point
Copy the full SHA 4738cc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98c7580 - Browse repository at this point
Copy the full SHA 98c7580View commit details
Commits on Aug 8, 2014
-
Fix an edgecase bug for no_trailing_semicolons
This is to fix an edge case bug where, inside of a multiline string, there is an interpolated string where the entire interpolation is a function call and does not contain a variable/string. Fixes #314
Configuration menu - View commit details
-
Copy full SHA for b9399ce - Browse repository at this point
Copy the full SHA b9399ceView commit details -
Merge pull request #315 from swang/fix_edgecase_for_no_trailing_semic…
…olons Fix an edgecase bug for no_trailing_semicolons
Configuration menu - View commit details
-
Copy full SHA for d8c5fbb - Browse repository at this point
Copy the full SHA d8c5fbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ae1425 - Browse repository at this point
Copy the full SHA 5ae1425View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.5.2...v1.5.3