Add ignore elision option to spacing_after_comma rule #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbayley
force-pushed
the
spacing_after_comma
branch
2 times, most recently
from
9c871ca to
e169593
Compare
@aminland This option added to the `spacing_after_comma` rule allows it to ignore consecutive commas when skipping array elements. For example `[,, c,, e, f] = [1, 2, 3, 4, 5, 6]`. This is known as _[elision](jashkenas/coffeescript#4796. Closes aminland/coffeelint2#5.
danielbayley
force-pushed
the
spacing_after_comma
branch
from
b6dc45f to
638fc9a
Compare
UziTech
requested changes
Feb 5, 2020
|
nvm I'll add the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option added to the
spacing_after_commarule allows itto ignore consecutive commas when skipping array elements. For example
[,, c,, e, f] = [1, 2, 3, 4, 5, 6]. This is known aselision. Closes aminland/coffeelint2#5.