Check that the repo ID hasn't changed to prevent repo-jacking #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome 💯 |
|
Thanks for the idea! The implementation was indeed not quite complete, and at the wrong place IMO as we do trigger updates in the background etc. Anyway I ran with it over at #1411 so closing this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to prevent "repo-jacking", which can happen if a GitHub user changes their username. It happened once last year when somebody managed to repo-jack the phpass library. You can defend against repo-jacking by checking that the repo ID hasn't changed.
Unfortunately I haven't been able to test this code properly. I've tried to build and run packagist in a VM, but something is wrong with my setup and I haven't been able to trigger this part of the code.