KEMBAR78
Clippy by wx257osn2 · Pull Request #11 · cordx56/rustowl · GitHub
Skip to content

Clippy #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Feb 14, 2025
Merged

Clippy #11

merged 25 commits into from
Feb 14, 2025

Conversation

@wx257osn2
Copy link
Contributor

No description provided.

@wx257osn2
add clippy on CI
67f9c74
@wx257osn2
use saturating_sub
0606c91
@wx257osn2
add Default impl
2d9f4fb
@wx257osn2
use contains_key
81c3e3d
@wx257osn2
use copied
2a3cf2e
@wx257osn2
replace with &mut[_] instead of &mut Vec
58abae0
@wx257osn2
use and_then
d3f1408
@wx257osn2
remove trivial conversion
0533bb4
@wx257osn2
collapse match
3975835
@wx257osn2
use matches!
4f4cd4d
@wx257osn2
merge if blocks
3b8f3d1
@wx257osn2
remove explicit clone for the type implements Copy trait
8467fe3
@wx257osn2
use iter instead of into_iter
e0f6e90
@wx257osn2
remove redundant return
daa6216
@wx257osn2
elide lifetime
b688d40
@wx257osn2
annotate explicitly
1d0d4d9
@wx257osn2
suppress warning
8c89b51
@wx257osn2
remove needless borrow
3418b6f
@wx257osn2
use next instead of nth(0)
1ed473a
@wx257osn2
use is_some instead of redundant pattern matching
a9e76fa
@wx257osn2
use if let instead of match
0bdeb1d
@wx257osn2
use to_string instead of format!
7c7390f
@wx257osn2
use Path instead of PathBuf
ea99ebd
@wx257osn2
unmut
57e88e7
@wx257osn2
use function directly instead of redundant closure
27018ea
cordx56
cordx56 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Owner

@cordx56 cordx56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late review.
It looks fine! Thank you.

@cordx56 cordx56 merged commit 99a9907 into cordx56:main Feb 14, 2025
@wx257osn2
Copy link
Contributor Author

🙌

@wx257osn2 wx257osn2 deleted the clippy branch February 15, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cordx56 cordx56 cordx56 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wx257osn2 @cordx56