-
-
Notifications
You must be signed in to change notification settings - Fork 441
Backport 'Fix image editor permissions for spaces' admins' to v0.28 #14506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alecslupu
merged 2 commits into
release/0.28-stable
from
backport/0.28/fix-image-editor-permissions-f-13772
Apr 9, 2025
Merged
Backport 'Fix image editor permissions for spaces' admins' to v0.28 #14506
alecslupu
merged 2 commits into
release/0.28-stable
from
backport/0.28/fix-image-editor-permissions-f-13772
Apr 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Permission for user granted as admin to edit images * remove change * reverting change * Add permission specs * fix for assemblies admin permissions * updated permissions for conferences * updated participaroty process permissions spec * removed initative permissions for image upload * removed spec from initiatives * removed role checker in initatives * Update decidim-admin/app/permissions/decidim/admin/permissions.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * refactored method in assemblies permissions * refactored conference admin permissions * updated description in assemblies * refactored particpatory processes method * refactored admin permssions for image editor * process admin spec added checks for proposals * commiting changes to permissions to re-write functionality * removed from participartory processes (refactor) * removed from conferences * removed permissions from assembiles * reverting attaching images in proposals in admin spec * Revert "removed permissions from assembiles" This reverts commit 1ab3c8a. * Revert "removed from conferences" This reverts commit 2a9e518. * editor_image object permissions check for processed re-added * moved method above editor_image check to fix pipeline * removed metrics block, not present in develop --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
alecslupu
commented
Apr 9, 2025
decidim-assemblies/spec/permissions/decidim/assemblies/permissions_spec.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/spec/permissions/decidim/conferences/permissions_spec.rb
Outdated
Show resolved
Hide resolved
...participatory_processes/spec/permissions/decidim/participatory_processes/permissions_spec.rb
Outdated
Show resolved
Hide resolved
greenwoodt
approved these changes
Apr 9, 2025
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Pull Requests that are a backport for a fixed bug
configuration
module: admin
module: assemblies
module: blogs
module: conferences
module: core
module: initiatives
module: participatory processes
module: proposals
release: v0.28
Issues or PRs that need to be tackled for v0.28
release: v0.29
Issues or PRs that need to be tackled for v0.29
release: v0.30
Issues or PRs that need to be tackled for v0.30
type: fix
PRs that implement a fix for a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #13772 to v0.28