adds role=radio to img alt=foo allowances #3320
Conversation
A `role=radio` was meant to be an allowance for an `img alt=foo`, but it had mistakenly been left out of the spec. ARIA in HTML is fixing this oversight, w3c/html-aria#381, so this PR is to match this added allowance.
There was a problem hiding this comment.
Thanks Scott. Would you be up for adding a passing integration test for this?
https://github.com/dequelabs/axe-core/tree/develop/test/integration/rules/aria-allowed-attr
|
@WilcoFiers would this be a new type of integration test then? it looks like what's in that folder now is divs with allowed roles and attributes. but this change is for the img element role allowances. maybe i'm missing something here. |
|
@scottaohara You are right. Apologies. I added the wrong link. This is about what roles are allowed, not what attributes: |
There was a problem hiding this comment.
LGTM. Thank you again @scottaohara!
For the books; I reviewed this PR for security.
2 participants
A
role=radiowas meant to be an allowance for animg alt=foo, but it had mistakenly been left out of the spec.ARIA in HTML is fixing this oversight, w3c/html-aria#381, so this PR is to match this added allowance.