KEMBAR78
Update `remoteUser` info by bamurtaugh · Pull Request #148 · devcontainers/spec · GitHub
Skip to content

Update remoteUser info #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2022
Merged

Update remoteUser info #148

merged 3 commits into from
Dec 2, 2022

Conversation

@bamurtaugh
Copy link
Member

@bamurtaugh bamurtaugh commented Dec 2, 2022 •
edited
Loading

To address the outdated reference mentioned here.

Next steps:

@bamurtaugh bamurtaugh requested a review from a team as a code owner December 2, 2022 18:33
@bamurtaugh bamurtaugh changed the title Update devcontainerjson-reference.md Update remoteUser info Dec 2, 2022
This was referenced Dec 2, 2022
Merged
Merged
Closed
samruddhikhandale
samruddhikhandale reviewed Dec 2, 2022
View reviewed changes
samruddhikhandale
samruddhikhandale reviewed Dec 2, 2022
View reviewed changes
@bamurtaugh @samruddhikhandale
Update docs/specs/devcontainerjson-reference.md
6388560 
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
samruddhikhandale
samruddhikhandale approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks. ✨

ℹ️ The cpp example in this PR is great and makes a clear point. However, as this PR links to specific lines in the images/templates repo, it is very susceptible to breaking. 🤔

I am good to approve, but maybe we need to be update URLs if cpp image/template updates (which should be rare I think)?

@bamurtaugh
Copy link
Member Author

Thanks for the quick review and great help, @samruddhikhandale!

Makes sense on breakages. Let's go ahead and merge since I agree it's nice to have a concrete example, and we'll just be aware that we'll need to be cautious if there are major changes. An alternative is to just link to the whole file rather than specific lines, but I think it's really helpful to point the user to the specific lines.

@bamurtaugh bamurtaugh merged commit 67d2817 into main Dec 2, 2022
@bamurtaugh bamurtaugh deleted the bamurtaugh-user branch December 2, 2022 19:34
@chrmarti
Copy link
Contributor

chrmarti commented Dec 5, 2022

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

@chrmarti chrmarti Awaiting requested review from chrmarti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bamurtaugh @chrmarti @samruddhikhandale