KEMBAR78
Implementing a tui dashboard for paddler as an alternative to using the dashboard web model. by Propfend · Pull Request #31 · intentee/paddler · GitHub
Skip to content

Conversation

Propfend
Copy link
Contributor

@Propfend Propfend commented Dec 4, 2024

No description provided.

Copy link
Contributor

@mcharytoniuk mcharytoniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks great. Thank you for the contribution. I have two issues to resolve though:

  1. table item sizes
  2. making sure all the ratatui_dashboard modules are behind a feature flag

pub mod agent;
pub mod balancer;

#[cfg(feature = "ratatui_dashboard")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far the PR looks great. Can you make sure that ratatui_dashboard is behind a feature flag and Paddler works and compiles without ratatui_dashboard feature flag enabled?

@mcharytoniuk mcharytoniuk merged commit 8cce384 into intentee:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants